Compatibility with bokeh 0.12.10dev #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The push build is passing. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bokeh is finally stabilizing it's API around exporting and embedding plots, which has involved some churn in the API before everything settles down. This PR switches to the now public
get_screenshot_as_pngfunction and replicates the functionality of the now deprecatednotebook_divfunction.In future we will also switch away from generating a single combined
notebook_divand split the HTML from the JS code, which will give us JupyterLab support (at least for static bokeh plots). For now this will maintain compatibility with the latest bokeh version.