Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Reimplement Path, Contours and Polygons plots #1991
Over the past few months I've slowly been laying the groundwork to support more powerful Path, Contours and Polygons elements and in this PR I am also finally exposing this new functionality in plotting classes. This PR finishes off some final issues with the internally facing API and will reimplements the plotting classes based on this new API.
Here is a demo of the new (and old) features.
This PR will address the following issues:
and will allow me to finish off my geopandas interface in geoviews:
Looks good. My main comments are:
If you haven't added material it would be good to see more examples (e.g of the split method).
Anyway, none of this is critical and once a few of my comments above are addressed (typos, stray print and other minor things), I'm happy to merge. The main other thing I would like is more examples for the docs.
This is a result of two things 1) it's no longer overlaid by default and b) contours now returns a single
Not sure what you're referring to, looks fine to me. Anyway, I completely overhauled the element reference notebooks adding more material.
I'm working on a "Working with Geometries" user guide which will cover stuff like this. Will see how far I get with that, but I can add it in a later PR.
Should contours get a compatibility flag in config? If we find ourselves with a number of small backwards incompatibility issues, we could group them under a new config flag.
That doesn't need to be decided right away and I'll merge once you get rid of that stray print and fix that typo.