New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for datetime axis on Image #2023

Merged
merged 14 commits into from Oct 27, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Oct 26, 2017

Adds support for datetime axes on Image, SheetCoordinateSystem, BoundingBox and Slice. The basics are all working including instantiation of an Image with datetime bounds and slicing and indexing. Will make it possible to generate datashaded images with datetime axes.

screen shot 2017-10-26 at 4 27 42 am

@jbednar

This comment has been minimized.

Member

jbednar commented Oct 26, 2017

Excellent!!!

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 26, 2017

Since this is the first modification to SheetCoordinateSystem and BoundingBox since it moved into HoloViews, one of @jbednar and @ceball can have the great honor of reviewing this PR.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 26, 2017

While I think Image will correctly retain timezone information, I think datashade operations will discard them. I can't say I have a strong desire to tackle that issue right now.

@jbednar

This comment has been minimized.

Member

jbednar commented Oct 26, 2017

Since I got to it first, I will nominate @ceball. :-)

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 26, 2017

Needs lots of tests still of course.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 26, 2017

Also worth noting that it's currently using microsecond precision, switching to nanosecond precision introduces issues that are hard to handle correctly.

@jbednar

This comment has been minimized.

Member

jbednar commented Oct 26, 2017

When this is done, maybe open an issue about the nanosecond precision issues and say that it's not something we expect to fix, but that if someone wants to use it for that purpose then here's what they would need to fix.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 26, 2017

Okay, this is ready to review now. I've added a bunch of unit tests for the utilities and for the interfaces. Iris does not like datetime coordinates apparently so I've had to skip those tests.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 26, 2017

This output:

HoloMap containing 28 items of type RGB
---------------------------------------

Key Dimensions: 
Date: Oct 25 2012 01:00 UTC...Nov 02 2012 16:00 UTC 
Layer Height (hPa): 850...1000 
Constant Dimensions: 
Frame: None...None 
Deep Dimensions: 
x: 0...400.0 
y: 0...350.0
R: 0...1 
G: 0...1 
B: 0...1 

changed to this:

HoloMap containing 28 items of type RGB
---------------------------------------

Key Dimensions: 
Date: Oct 25 2012 01:00 UTC...Nov 02 2012 16:00 UTC 
Layer Height (hPa): 850...1000 
Constant Dimensions: 
Frame: None...None 
Deep Dimensions: 
x: 0...400 
y: 0...350 
R: 0...1 
G: 0...1 
B: 0...1 

The latter is more correct so I've updated the test data but the push build isn't pulling it for some reason. It should still work so this can be merged after review.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 27, 2017

I'm going to go ahead and merge this myself since other work depends on it and the best smoke test is likely using it a lot in action. @ceball promised he'd take a more in depth look even after merging.

@philippjfr philippjfr merged commit b129189 into master Oct 27, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 79.995%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the datetime_image branch Oct 28, 2017

@pyup-bot pyup-bot referenced this pull request Nov 3, 2017

Closed

Update holoviews to 1.9.0 #104

@pyup-bot pyup-bot referenced this pull request Nov 13, 2017

Closed

Update holoviews to 1.9.1 #120

@pyup-bot pyup-bot referenced this pull request Dec 12, 2017

Merged

Update holoviews to 1.9.2 #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment