New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box whisker improvements #2187

Merged
merged 2 commits into from Dec 11, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Dec 11, 2017

Improved BoxWhisker element docstrings as requested in #1838 and fixed hover issues as requested in #2142.

@philippjfr philippjfr added this to the v1.9.2 milestone Dec 11, 2017

representing the lowest datum still within 1.5 IQR of the lower
quartile, and the highest datum still within 1.5 IQR of the upper
quartile. Any points falling outside this range are shown as
distinct outlier points.

This comment has been minimized.

@jlstevens

jlstevens Dec 11, 2017

Member

maybe 'standard Tukey boxplot definition' if it is standard? Otherwise sounds like it is just a definition for boxplots...

This comment has been minimized.

@jlstevens

jlstevens Dec 11, 2017

Member

Might be worth expanding the name to 'John W. Tukey'...

This comment has been minimized.

@philippjfr

philippjfr Dec 11, 2017

Member

Tukey box plots is the common way to refer to this style of plot, don't think the full name adds anything.

This comment has been minimized.

@philippjfr

philippjfr Dec 11, 2017

Member

To quote Wikipedia:

But the ends of the whiskers can represent several possible alternative values, among them:

the lowest datum still within 1.5 IQR of the lower quartile, and the highest datum still within 1.5 IQR of the upper quartile (often called the Tukey boxplot)

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 11, 2017

One minor docstring comment. Otherwise looks good.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 11, 2017

Looks good. Merging.

@jlstevens jlstevens merged commit acf1c6f into master Dec 11, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 81.109%
Details
s3-reference-data-cache Test data is cached.
Details

@pyup-bot pyup-bot referenced this pull request Dec 12, 2017

Merged

Update holoviews to 1.9.2 #139

@philippjfr philippjfr deleted the box_whisker_improvements branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment