New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Compositor does not make superfluous copies #2194

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Dec 11, 2017

A partial workaround/fix for #2129. The correct fix will be to ensure that a Compositor transfers the ID a stream is registered to when it is applied but since we do not ship any actual Overlay compositors by default this fix should be sufficient for 1.9.2.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 11, 2017

Looks like the correct fix to me! I'll wait for the tests to pass anyhow...

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 11, 2017

To clarify that I am not contradicting you, this is the right thing to do (don't touch the overlay unless the patterns apply) but it isn't the complete fix which is something we need to describe in an issue.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 11, 2017

Tests have passed. Merging.

@jlstevens jlstevens merged commit 9aee63f into master Dec 11, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on compositor_stream_id_bug at 81.177%
Details
s3-reference-data-cache Test data is cached.
Details

@pyup-bot pyup-bot referenced this pull request Dec 12, 2017

Merged

Update holoviews to 1.9.2 #139

@philippjfr philippjfr deleted the compositor_stream_id_bug branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment