New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trisurface renamed to TriSurface #2219

Merged
merged 6 commits into from Dec 20, 2017

Conversation

Projects
None yet
2 participants
@jlstevens
Member

jlstevens commented Dec 19, 2017

The branch is misnamed after deciding that TriMesh was not the inconsistent name but Trisurface was.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 19, 2017

@philippjfr Not sure there is much more to this PR other than having you check that the plotly TriSurface/Trisurface works for you (I can't test it because of some odd webgl error!)

@philippjfr

This comment has been minimized.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 19, 2017

Thanks..I'll fix those shortly.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 19, 2017

That should be the rest of them. Happy to merge when the tests pass?

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 19, 2017

There are two failures that look like they will require the test data to be updated.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Dec 19, 2017

There are two failures that look like they will require the test data to be updated.

Seems likely if you updated the group.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 20, 2017

I have now updated the test data.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Dec 20, 2017

PR build passing, merging.

@philippjfr philippjfr merged commit ae8e941 into master Dec 20, 2017

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on trimesh_rename at 80.291%
Details
s3-reference-data-cache Test data is cached.
Details

philippjfr added a commit that referenced this pull request Feb 11, 2018

@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018

@philippjfr philippjfr deleted the trimesh_rename branch Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment