New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook improvements #2220

Merged
merged 3 commits into from Jan 3, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Dec 20, 2017

Various notebook improvements:

  • Added list of supported data formats to Tabular Datasets user guide
  • Fixed Plotting with Bokeh axis example
  • Added section about bokeh interactive legends to Plotting with Bokeh (as requested in #1265)

@philippjfr philippjfr added the docs label Dec 20, 2017

"* 0D: BoxWhisker, Spikes, Distribution, \n",
"* 1D: Scatter, Curve, ErrorBars, Spread, Bars, BoxWhisker\n",
"* 2D: Points, HeatMap, Bars, BoxWhisker, Bivariate\n",
"* 3D: Scatter3D, Trisurface, VectorField, BoxWhisker, Bars\n",

This comment has been minimized.

@jlstevens

jlstevens Dec 21, 2017

Member

Should now be TriSurface.

This comment has been minimized.

@philippjfr

philippjfr Dec 21, 2017

Member

Good catch.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Dec 21, 2017

Looks good, other than updating the spelling to TriSurface, I am happy to merge.

@@ -244,15 +244,15 @@
"metadata": {},
"outputs": [],
"source": [
"%%opts Overlay [show_legend=False height=400 width=600] ErrorBars (line_width=5) Scatter(alpha=0.2 size=6)\n",
"%%opts Overlay [show_legend=False height=400 width=600] ErrorBars (line_width=5) Scatter [jitter=0.2] (alpha=0.2 size=6)\n",

This comment has been minimized.

@jlstevens

jlstevens Dec 21, 2017

Member

Just checking that jitter complains if it is used without categorical axes (it should)....

This comment has been minimized.

@philippjfr

philippjfr Jan 3, 2018

Member

Opened an issue here: #2236

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jan 3, 2018

@jlstevens Ready to merge.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 3, 2018

Looks good. Merging!

@jlstevens jlstevens merged commit fcdbca6 into master Jan 3, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 81.195%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the notebook_improvements branch Jan 13, 2018

philippjfr added a commit that referenced this pull request Feb 9, 2018

@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment