New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bokeh server Callback queue bug #2239

Merged
merged 1 commit into from Jan 3, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jan 3, 2018

A previous PR seems to have introduced a bug which clears the event queue before it is processed when using on_event based stream callbacks such the Tap event.

Fixes: #2231

@@ -388,7 +388,6 @@ def process_on_event(self):
if not self._queue:
self._active = False
return
self._queue = []

This comment has been minimized.

@philippjfr

philippjfr Jan 3, 2018

Member

Not evident from looking at this diff but the queue is already being cleared four lines below.

This comment has been minimized.

@jlstevens

jlstevens Jan 3, 2018

Member

Annoying!

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jan 3, 2018

Annoying one line fix! Anyway, looks good. Merging.

@jlstevens jlstevens merged commit d52c1d7 into master Jan 3, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@philippjfr

This comment has been minimized.

Member

philippjfr commented Jan 3, 2018

This desperately needs tests so I've made a note in #1488.

@philippjfr philippjfr deleted the server_event_fix branch Jan 13, 2018

philippjfr added a commit that referenced this pull request Feb 9, 2018

@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment