New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Travis testing dependencies to latest versions #2329

Merged
merged 15 commits into from Feb 13, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Feb 10, 2018

Bumps the matplotlib version on Travis to 2.1.2 (i.e. latest). This is long overdue and hopefully will finally make the transient test failures disappear. Will require rebuilding test data of course.

@philippjfr philippjfr added the testing label Feb 10, 2018

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 11, 2018

Hopefully this works well. Just to be safe, we should make an explicit backup of the testing data before merging this PR. It will take a little while before we have a feel about the transients being better or worse so it is worth making sure we have the old testing data in case we have to revert in the worst case scenario.

@philippjfr philippjfr referenced this pull request Feb 12, 2018

Closed

Hotfix v1.9.4 #2337

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 13, 2018

Looking quite hopeful that this resolves our transient issues. I restarted builds once so that's now 8 runs without a transient failure. Now that I've updated matplotlib it's time to start doing the same with pandas, dask, datashader and bokeh.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 13, 2018

I'd also like to switch from listing the travis dependencies in the .travis.yaml to using the environment.yml, with strict version requirements which will be guaranteed to work for testing and doc building.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 13, 2018

Uncovered a few bugs as part of this update. I expect one unit test to fail on this build, which I'll resolve in the morning. Once this is merged (along with the table PR) I think we're good to go for 1.9.4.

@philippjfr philippjfr changed the title from Bumped tested matplotlib version to latest to Bumped Travis testing dependencies to latest versions Feb 13, 2018

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 13, 2018

Ready to merge now. I'll be restoring the disabled test in this PR #2338. After a lot of test runs I can confidently say that transients are reduced but unfortunately not eliminated.

@@ -73,12 +73,12 @@ def test_get_size_single_plot(self):
def test_get_size_row_plot(self):
plot = self.renderer.get_plot(self.image1+self.image2)
w, h = self.renderer.get_size(plot)
self.assertEqual((w, h), (576, 258))
self.assertEqual((w, h), (576, 255))

This comment has been minimized.

@jlstevens

jlstevens Feb 13, 2018

Member

At least the changes here are small...

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 13, 2018

Looks good. I'm a little surprised at the changes in the size tests but at least the changes are small. As you said, this is long overdue so I am happy to merge now.

@jlstevens jlstevens merged commit 09e3905 into master Feb 13, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.7%) to 82.014%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the travis_mpl_master branch Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment