New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass operation to Operation hooks #2334

Merged
merged 1 commit into from Feb 11, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Feb 11, 2018

Recently we added hooks to operations which could do some pre- and post-processing on the data. The current implementation only passes the unprocessed and processed objects to the pre- and post-hook respectively when it would be more general if it also passed in the operation. This can be useful e.g. to apply pre-processing the operation parameters. The specific use-case I have in mind is ensuring that GeoViews returns RangeXY stream bounds in the correct coordinate system.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 11, 2018

Looks good and the tests are green. It would be an API change if libraries other than geoviews were using this mechanism but I am fairly sure this only affects geoviews. Merging.

@jlstevens jlstevens merged commit 5a7fb40 into master Feb 11, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on operation_hook_args at 81.32%
Details
s3-reference-data-cache Test data is cached.
Details
@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 11, 2018

Right, this "feature" hasn't been in a release yet so technically it's not an API change.

@philippjfr philippjfr deleted the operation_hook_args branch Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment