New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix v1.9.4 #2337

Closed
wants to merge 11 commits into
base: hotfix_1.9.3
from

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Feb 12, 2018

Unfortunately a regression in the regrid operation was introduced in the hotfix 1.9.3 branch. This PR represents the fixes for that branch, and should not be merged.

Other PRs that would be good to get into this release are:

The latter would be good to ensure that we are actually testing against the latest versions of different libraries, which is what caused the regrid bug to slip through.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 14, 2018

Once we get the flake fixes in #2340 merged this will be ready to release.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 14, 2018

I've now cherry-picked the relevant flake fixes onto this branch. Should be ready to release now.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 16, 2018

All the PRs mentioned are now merged. Maybe it is worth also getting #2346 in as that is bug fixes too?

@jbednar

This comment has been minimized.

Member

jbednar commented Feb 16, 2018

Several of the items in #2346 look like they are for Elements not present in 1.9.4, though...

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 16, 2018

That is a good point. If it is too much pain to cherry pick the commits that do apply to 1.9.4, then I suppose those fixes can simply be left out.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 16, 2018

That's okay, I'll remove those while cherry-picking.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 16, 2018

@jlstevens Now done, I think we can release this now.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 16, 2018

The key tests we expect to pass (flakes, nosetests) are now passing on both Python 2 and 3. I'm now preparing the release.

jlstevens and others added some commits Feb 16, 2018

@philippjfr philippjfr closed this Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment