New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datashader fixes #2344

Merged
merged 3 commits into from Feb 16, 2018

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Feb 15, 2018

Addresses another bug in the datashader handling of datetimes, when the range is not supplied with nanosecond resolution. Also adds a test and some extra handling for datashading empty objects.

@philippjfr philippjfr added the bug label Feb 15, 2018

@jbednar

This comment has been minimized.

Member

jbednar commented Feb 15, 2018

Looks good to me, but so did the old buggy way. :-/

@philippjfr philippjfr requested a review from jlstevens Feb 15, 2018

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 16, 2018

@jlstevens Ready to merge. Once you have I'll cherry-pick it onto the hotfix branch.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 16, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit ff47ad1 into master Feb 16, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 82.074%
Details
s3-reference-data-cache Test data is cached.
Details

philippjfr added a commit that referenced this pull request Feb 16, 2018

@philippjfr philippjfr deleted the datashader_dt_fixes branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment