New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode bytes in bokeh plots #2357

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Feb 20, 2018

Attempt to decode bytes types passed to bokeh plots. As part of the Intake project I'm building a HoloViews based plotting API, many of the data sources in this project includes bytes types even in Python3 which currently cannot be serialized by bokeh causing errors. In this API its not really practical to convert the bytes types to strings, so it would be helpful if we could just assume utf-8 encoding (which will be most common). This will of course not always work but based on my testing it works in most cases, which is better than the current case where it works in no cases.

@philippjfr philippjfr added the bokeh label Feb 20, 2018

@philippjfr

This comment has been minimized.

Member

philippjfr commented Feb 21, 2018

Ready to review/merge.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 22, 2018

Looks good though I think this issue needs more thorough investigation before we can be confident that we have the most general/robust fix. If you file an issue as a reminder to do that, I'm happy to merge this as a fix (even if it only a partial fix, it will handle more inputs that always erroring, as you say).

@jlstevens

This comment has been minimized.

Member

jlstevens commented Feb 22, 2018

Thanks for filing the issue. Merging.

@jlstevens jlstevens merged commit 5313b75 into master Feb 22, 2018

3 of 4 checks passed

s3-reference-data-cache Test data not cached, see details to rebuild.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 82.035%
Details

philippjfr added a commit that referenced this pull request Mar 1, 2018

@philippjfr philippjfr deleted the bokeh_bytes branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment