New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for looping edges in Chords element #2583

Merged
merged 2 commits into from Apr 19, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Apr 19, 2018

The operation that lays out the Chord paths did not take into account nodes connected to themselves. This PR ensures these no longer cause errors and are displayed as looping arcs.

@philippjfr philippjfr added the bug label Apr 19, 2018

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 19, 2018

Could you post a screenshot showing an example of what the loops look like?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 19, 2018

Sure, here's a simple example:

hv.Chord([('A', 'B', 10), ('B', 'A', 20), ('C', 'B', 100), ('C', 'C', 40)], vdims=['z'])

bokeh_plot

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 19, 2018

Ready to merge.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 19, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit 97bc1dd into master Apr 19, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on chord_self_reference at 82.703%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the chord_self_reference branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment