New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for empty options method call #2630

Merged
merged 2 commits into from Apr 30, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Apr 27, 2018

When calling the .options method without any arguments it would previously be an error. This PR ensures that condition is handled appropriately.

@philippjfr philippjfr added this to the v1.10.2 milestone Apr 27, 2018

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 27, 2018

Looks good to me. Merging.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 27, 2018

Unless you want to add a unit test first?

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 30, 2018

Added a quick unit test myself. I'll merge once the tests go green.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 30, 2018

Thanks, I'll go ahead and merge.

@philippjfr philippjfr merged commit 6a4bd34 into master Apr 30, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 83.266%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the options_empty branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment