New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug disabling axis labels with labelled option #2643

Merged
merged 1 commit into from May 3, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented May 2, 2018

The labelled plot option allows disabling axis labels, however in bokeh it is being ignored by the _update_plot method. This fixes the issue.

  • Add unit tests

@philippjfr philippjfr added this to the v1.10.3 milestone May 2, 2018

@philippjfr

This comment has been minimized.

Member

philippjfr commented May 3, 2018

@jlstevens Ready to merge. This one is pretty unfortunate and may prompt a 1.10.3 release (along with some other fixes I haven't created PRs for yet).

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 3, 2018

Is this a regression or just something that wasn't properly supported when it should have been? I'm fine with a 1.10.3 release though and the changes here look good so I'll merge.

@jlstevens jlstevens merged commit b8e96a6 into master May 3, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 83.268%
Details
s3-reference-data-cache Test data is cached.
Details
@philippjfr

This comment has been minimized.

Member

philippjfr commented May 3, 2018

Is this a regression or just something that wasn't properly supported when it should have been?

I think it's a regression, but I think it's one that snuck in at some point in the 1.9.x series (i.e. I don't think it's not a new bug in 1.10).

@philippjfr philippjfr deleted the fix_labelled_option branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment