New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant value datashader aggregation #2860

Merged
merged 4 commits into from Jul 6, 2018

Conversation

Projects
None yet
2 participants
@philippjfr
Copy link
Member

philippjfr commented Jul 6, 2018

Further fixes for datashader aggregation on an axis with a constant value (i.e. zero-range). Also fixes a datetime issue and some issues when cloning Image types.

  • Fixes #2858
  • Adds unit test
@jlstevens

This comment has been minimized.

Copy link
Member

jlstevens commented Jul 6, 2018

Looks good although it might be nice to avoid subclassing the clone method if possible. Happy to merge once the test data is updated and the tests are passing.

@philippjfr

This comment has been minimized.

Copy link
Member

philippjfr commented Jul 6, 2018

Ready to merge.

@jlstevens jlstevens merged commit 0a154d7 into master Jul 6, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 83.085%
Details
s3-reference-data-cache Test data is cached.
Details

philippjfr added a commit that referenced this pull request Jul 7, 2018

@philippjfr philippjfr deleted the image_ds_fixes branch Aug 5, 2018

@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment