If plot ranges cannot be determined use mpl autoscale view #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if valid_lim(t): | ||
| axis.set_ylim(top=t) | ||
| yset = True | ||
| axis.autoscale_view(scalex=not xset, scaley=not yset) |
There was a problem hiding this comment.
Seems like a reasonable change although why not invert the booleans and use the same names as matplotlib scalex and scaley? That would seem clearer to me...
|
Apparently some |
This ensures that the xlim and ylim on a plot correspond to the actual data limits at all times, allowing calculations based on these values to be performed
philippjfr
force-pushed
the
autoscale
branch
3 times, most recently
from
da8a183
to
96a886c
Compare
|
Ready to merge. |
|
Not sure why the reference data is complaining but this is still ready to merge. |
|
With the pr build passing, I'll merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the xlim and ylim on a plot correspond to the actual data limits at all times, allowing calculations based on these values to be performed.