New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tutorial section to explain DynamicMap groupby methods #667

Merged
merged 1 commit into from May 11, 2016

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented May 11, 2016

No description provided.

@jlstevens

This comment has been minimized.

Member

jlstevens commented May 11, 2016

Great! Thanks for updating the docs!

Ready to merge?

@philippjfr

This comment has been minimized.

Member

philippjfr commented May 11, 2016

Ready.

@jlstevens jlstevens merged commit 79924b8 into master May 11, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 69.467%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr removed the in progress label May 11, 2016

{
"cell_type": "markdown",
"metadata": {},
"source": [

This comment has been minimized.

@jbednar

jbednar May 11, 2016

Member

Line 714 below says "need to check" -- what's the answer to that question?

This comment has been minimized.

@philippjfr

philippjfr May 11, 2016

Member

Good question, looks like @jlstevens forgot to address his own question 😄 I think the statement is correct as is, as long as the dimension is unbounded on either end it will default to open mode.

This comment has been minimized.

@jbednar

jbednar May 11, 2016

Member

Ok, I'll remove the qualifier while I'm doing an editing pass on this tutorial to clean up the new changes.

This comment has been minimized.

@jlstevens

jlstevens May 11, 2016

Member

In that case we can remove that stray comment...oops!

Edit: Thanks Jim for cleaning it up and giving it another pass!

This comment has been minimized.

@jbednar

jbednar May 11, 2016

Member

Would "At least one of the declared key dimensions must have an unbounded range (i.e., with no upper bound specified)." be correct?

This comment has been minimized.

@jlstevens

jlstevens May 11, 2016

Member

I think so...though Philipp suggests it works if either bounds is None, including the lower bound? I just wonder how the scrubber handles that...does it decrease starting from the upper bound?

This comment has been minimized.

@jbednar

jbednar May 11, 2016

Member

It just ignores all the bounds, at present; all that matters is that one bound is not specified. I've clarified it to say that, but we're still deciding on the larger issue of how to describe these various modes.

@philippjfr philippjfr deleted the dynamic_groupby_tutorial branch May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment