New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for bokeh 0.12 compatibility #725

Merged
merged 7 commits into from Jun 21, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Jun 20, 2016

As the title says this PR makes HoloViews compatible with the upcoming bokeh 0.12 release. Since bokeh is going through rapid development cycles and we do not want to accumulate endless compatibility layers we are also dropping compatibility with 0.10 in this PR. The major component of this PR is in changing the way JSON patches are computed when using the widgets and callbacks, which has now been unified to use the same approach everywhere, bypassing the relatively slow patch diffing that bokeh uses by default and also dropping various hacks previously added to make things work across 0.10 and 0.11. This PR also does not yet add support for any of the new features in bokeh 0.12. Those should follow in future PRs; for now this PR just makes sure all existing functionality continues to work.

@philippjfr philippjfr changed the title from Initial fixes for bokeh 0.12 compatibility to Fixes for bokeh 0.12 compatibility Jun 20, 2016

@philippjfr

This comment has been minimized.

Member

philippjfr commented Jun 21, 2016

Ready to merge.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Jun 21, 2016

I'm happy to see 0.10 compatibility dropped and I like seeing Javascript removed. Unifying the approach (and also getting a speed up!) sounds great.

Merging.

@jlstevens jlstevens merged commit 564d747 into master Jun 21, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@philippjfr philippjfr removed the in progress label Jun 21, 2016

@jlstevens jlstevens deleted the bokeh_0.12_compatibility branch Jul 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment