New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of constant dimensions in xarray #817

Merged
merged 1 commit into from Aug 17, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Aug 17, 2016

This PR fixes handling of constant dimensions in the xarray interface of HoloViews. By default a select operation does not reduce the dimensionality of a HoloViews object, i.e. the dimensionality stays unchanged. Until we have proper support for constant dimensions this is probably the right approach, however xarray does convert coordinates to constant coordinates, which changes the shape of the array. This PR ensures that the shape of the arrays stays unchanged.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Aug 17, 2016

Looks ok, but I think we need to have a proper plan regarding constant dimensions across HoloViews. Not sure when we'll find the appropriate time to address that though...

Merging.

@jlstevens jlstevens merged commit 7a3ecd2 into master Aug 17, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on xarray_constant_fixes at 46.695%
Details
s3-reference-data-cache Test data is cached.
Details

@jlstevens jlstevens removed the in progress label Aug 17, 2016

@philippjfr philippjfr deleted the xarray_constant_fixes branch Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment