New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up CompositePlot instantiation #840

Merged
merged 6 commits into from Aug 31, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Aug 31, 2016

So I was about to add some code to different plots classes to attach streams and I got fed up with all the duplication in the composite plot constructors. I've moved everything to the base class cutting down a lot of the mess.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Aug 31, 2016

Ready to merge.

@jlstevens jlstevens merged commit eeb64b0 into master Aug 31, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 69.317%
Details
s3-reference-data-cache Test data is cached.
Details

@jlstevens jlstevens removed the in progress label Aug 31, 2016

@philippjfr philippjfr deleted the cleanup_composite_plots branch Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment