New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended dimension values support #859

Merged
merged 3 commits into from Sep 12, 2016

Conversation

Projects
None yet
2 participants
@jlstevens
Member

jlstevens commented Sep 12, 2016

This PR implements a feature request by @basnijholt on gitter to support numpy arrays and pandas Series as direct specifications for Dimension.values coupled with automatic de-duplication of values.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Sep 12, 2016

Tests are passing and I think this is ready to merge.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Sep 12, 2016

Looks good. Merging.

@philippjfr philippjfr merged commit e455738 into master Sep 12, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on extended_dimension_values_support at 71.056%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr removed the in progress label Sep 12, 2016

@philippjfr philippjfr deleted the extended_dimension_values_support branch Sep 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment