New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured DynamicOperation uses the set of keys when converting HoloMap #883

Merged
merged 1 commit into from Sep 23, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Sep 23, 2016

Fixes issue raised in #882

@philippjfr

This comment has been minimized.

Member

philippjfr commented Sep 23, 2016

Ready to merge when tests pass.

@philippjfr philippjfr added the bug label Sep 23, 2016

@jlstevens

This comment has been minimized.

Member

jlstevens commented Sep 23, 2016

Are there any tests for DynamicOperation?

Otherwise, I'm happy to merge.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Sep 23, 2016

Yes there are a few.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Sep 23, 2016

Ok, there is one test failure but it is only a transient. Merging.

@jlstevens jlstevens merged commit 19dc6b9 into master Sep 23, 2016

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 71.855%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the dynamic_function_set branch Oct 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment