New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added throttling for bokeh callback events #892

Merged
merged 1 commit into from Sep 30, 2016

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Sep 30, 2016

This implements throttling for bokeh callback events by making the Comm send acknowledgement events back to JS whenever it has finished processing an event sent to it from JS. In future this code will move onto a general WidgetManager class.

@jbednar

This comment has been minimized.

Member

jbednar commented Sep 30, 2016

Excellent.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Sep 30, 2016

Ok, I'm happy with this and I'm happy to merge. The points we intend to improve on in future:

  • Abstracting this out to WidgetManager as Philipp says.
  • Keeping the comm state somewhere more suitable than HoloViewsWidget.

@philippjfr Ready to merge now?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Sep 30, 2016

Yes merge away!

@jlstevens jlstevens merged commit 6b85089 into master Sep 30, 2016

0 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
coverage/coveralls Coverage pending from Coveralls.io
Details

@philippjfr philippjfr deleted the callback_throttle branch Oct 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment