New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Bounds stream to None #913

Merged
merged 1 commit into from Oct 7, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Oct 7, 2016

Any arbitrary default values are unlikely to really make sense and Bounds should also allow None in other cases.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 7, 2016

Any arbitrary default values are unlikely to really make sense

Well, I already made use of these values in a Bounds stream I used - my code snapped to the nearest available key which meant any value would do.

I also have a vague memory of the default of NumericTuple being specified as None actually becomes (None, None) or a similar tuple of the specified length. If that is true, then the length should be specified as four and the default is really (None,None,None,None).

I might be wrong but this is worth checking. If it really is None, I can merge and then update the code that made use of this default value.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 7, 2016

It really is None.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 7, 2016

Must be remembering an old param bug then. Merging.

@jlstevens jlstevens merged commit 164e79e into master Oct 7, 2016

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the streams_fix branch Oct 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment