New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh adjoined histogram adds support for live colormapping #928

Merged
merged 6 commits into from Oct 12, 2016

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Oct 12, 2016

An adjoined histogram in bokeh now automatically shares the color mapper of whatever plot it is adjoined to it and adds a box_select tool with a CustomJS to update that colormapper based on the current selection. Since this callback is pure JS this will also work on static export.

dynamic_colormap

@jbednar

This comment has been minimized.

Member

jbednar commented Oct 12, 2016

Cool! The code looks clean to me, but maybe better if @jlstevens merges it just to be sure.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 12, 2016

Based off #927, so that should be merged first.

@jbednar

This comment has been minimized.

Member

jbednar commented Oct 12, 2016

#927 is merged, so can this be merged now?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 12, 2016

Yes, I just have to rebuild test data first (because you broke it 😄).

@jbednar

This comment has been minimized.

Member

jbednar commented Oct 12, 2016

Is the test data in github? Seems easier just to edit that one character.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 12, 2016

PR #927 has now been merged and this functionality is certainly very nice (especially as it doesn't need a live server). My only concern is that it doesn't seem hugely intuitive to me to use the box select tool on a side histogram. Other than that, I am happy to merge.

@jbednar

This comment has been minimized.

Member

jbednar commented Oct 12, 2016

The box select tool seems very intuitive to me, in terms of mouse clicking; it's just that ideally the visual representation of the selection would not be a box but a range of histogram bins. I.e., the same clicks should do the same thing, but the selected area should show bins, not portions of bins, ideally. Still, that seems like a nicety that could be added someday, and shouldn't hold up this PR.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 12, 2016

It is certainly nice functionality! Merging.

@jlstevens jlstevens merged commit a00ffbf into master Oct 12, 2016

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
s3-reference-data-cache Test data is cached.
Details

@jbednar jbednar deleted the adjoined_hist_js branch Oct 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment