New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website update #936

Merged
merged 11 commits into from Oct 28, 2016

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Oct 17, 2016

No description provided.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 17, 2016

Ah, I said I would add a bit of text describing mybinder and holoviews-contrib. Don't merge till I've done that!

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 21, 2016

@jlstevens Any update on this?

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 21, 2016

@philippjfr I'll take a look at it now.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 27, 2016

Sorry I didn't get to this earlier! My first change is this:

image

I'm not sure this is the best approach but I think a link to the dev part of the website would be useful.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 27, 2016

My next change is to try and shorten the first paragraph in the Homepage notebook while also linking to holoviews-contrib. I think we agree that the original homepage had a bit too much text before presenting the first visualization. I also think the following paragraph covers the key points.

As this is an edit to the first thing people see on the homepage, we should all make sure we are happy with it before making it live!

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 27, 2016

I've also linked to holoviews-contrib from the tutorials index. I think this conclude the most urgent changes I wanted to make to the website at this time.

We should review all these changes carefully and if we are happy, we can then merge and update the website.

@@ -9,7 +9,7 @@ you may also try out live copies on `mybinder.org
explore many other examples in our `contrib repository
<https://github.com/ioam/holoviews-contrib>`_. Lastly, for the most
responsive experience, you can install HoloViews and try out the
`tutorial notebooks`_ for yourself.
tutorial notebooks for yourself.

This comment has been minimized.

@jbednar

jbednar Oct 28, 2016

Member

I don't know what this was meant to link to, but it wasn't linking to anything anymore.

This comment has been minimized.

@jlstevens

jlstevens Oct 28, 2016

Member

This isn't a broken link - it gets replaced with the right link based on the current version in setup.py. See the replacement here.

This comment has been minimized.

@jbednar

jbednar Oct 28, 2016

Member

Ah. Way too tricky! In that case, why is it linking to the bogus 1.5.0 version then on the live site, since setup.py was surely declaring 1.6.2?

This comment has been minimized.

@jlstevens

jlstevens Oct 28, 2016

Member

It works just fine which is why the dev version is correctly pointing to 1.6.2 - the issue is that we need to copy the files from the dev version over to the main website on release. I think what happened is that the website building infrastructure broke at some point so that the files must have been stale.

What I do know is that there are tricky bits to updating the docs/website but thankfully this isn't one of them! :-)

This comment has been minimized.

@jbednar

jbednar Oct 28, 2016

Member

Do we have a way to do website fixes for a particular release, rather than for the current master? I.e. if we wanted to update the website now, then it would be updated with the git version of holoviews, not the latest release. Are we only able to update it just after a release?

philippjfr and others added some commits Oct 28, 2016

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 28, 2016

Thanks for the updates. Merging and updating the website.

@philippjfr philippjfr merged commit 83b82a9 into master Oct 28, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@philippjfr philippjfr deleted the website_update branch Jan 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment