New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh notebook tests #941

Merged
merged 2 commits into from Oct 20, 2016

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Oct 19, 2016

Ready to merge now. Bokeh_Elements is now tested in Python2 at least.

@philippjfr philippjfr changed the title from Bokeh tests to Bokeh notebook tests Oct 19, 2016

@jbednar

This comment has been minimized.

Member

jbednar commented Oct 20, 2016

Looks good to me.

@jbednar jbednar merged commit 63be325 into master Oct 20, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.8%) to 75.737%
Details
s3-reference-data-cache Test data is cached.
Details

@jbednar jbednar deleted the bokeh_tests branch Oct 20, 2016

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 20, 2016

Certainly better than no bokeh tests at all! What would it take to get the bokeh tests working with Python 3?

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 20, 2016

Getting it to sort predictably for comparison. I've not really figured out why that's so difficult.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 20, 2016

Python 2's heterogenous sorting vs Python 3's homogenous only sorting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment