New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rounding issues in DynamicMap #944

Merged
merged 2 commits into from Oct 21, 2016

Conversation

Projects
None yet
2 participants
@philippjfr
Member

philippjfr commented Oct 21, 2016

Fixes issue #601 involving a bug where dimension values were rounded up outside a Dimension range before being sent to JS, causing the DynamicMap to throw out of range errors. I now round to 11 decimal places and then throw away the last digit.

philippjfr added some commits Oct 21, 2016

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 21, 2016

PR build doesn't include the nbpublisher update for the bokeh tests yet. PR build should pass though.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Oct 21, 2016

Throwing the last digit should always reduce the abs() value so this approach seems fairly sensible. I'm happy to merge if you feel it is ready and tested.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Oct 21, 2016

Yes, ready to merge.

@jlstevens jlstevens merged commit af3bc4f into master Oct 21, 2016

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 75.743%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr deleted the dynamic_round_bug branch Jan 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment