New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure batched plots in Overlays are recognized as overlaid #967

Merged
merged 2 commits into from Nov 4, 2016

Conversation

Projects
None yet
3 participants
@philippjfr
Member

philippjfr commented Nov 2, 2016

Previous batched plots (i.e. NdOverlays of batchable Elements) that were themselves overlaid were not correctly registered as such causing them to override axis ranges, widths, heights etc. This fixes this behavior.

style=style, uniform=self.uniform,
zorder=zorder, **{k: v for k, v in
self.handles.items() if k in
self._passed_handles})

This comment has been minimized.

@jbednar

jbednar Nov 3, 2016

Member

Formatting could be improved starting with **.

This comment has been minimized.

@philippjfr

philippjfr Nov 3, 2016

Member

Yea auto-indenting made a mess here.

@jbednar

This comment has been minimized.

Member

jbednar commented Nov 3, 2016

Looks good to me.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Nov 4, 2016

Looks good to me too. Merging.

@jlstevens jlstevens merged commit 42396b2 into master Nov 4, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 75.718%
Details
s3-reference-data-cache Test data is cached.
Details

@philippjfr philippjfr referenced this pull request Nov 21, 2016

Closed

DynamicMap frozen #706

@philippjfr philippjfr deleted the batched_overlaid_bug branch Dec 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment