New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter mode deprecation #969

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jlstevens
Member

jlstevens commented Nov 4, 2016

This PR is work-in-progress and aims to remove the DynamicMap counter mode now that streams offer a much more principled way of achieving the same thing.

TODO:

  • Update the DynamicMap tutorial.
  • Test this works properly with other notebooks using DynamicMap.
  • Make sure we are clear about get_dynamic_item and associated semantics.
  • We probably no longer need both mode and call_mode.
  • Before the assumption was that is call_mode='key' then the mode was 'bounded'. With streams, this is not quite right: bounded should apply if any of the kdims are bounded.
@jlstevens

This comment has been minimized.

Member

jlstevens commented Nov 4, 2016

Unit tests need updating and the DynamicMap tutorial also needs to be updated. I've checked the DynamicMap tutorial works up to the point where counter mode is introduced. Seems like we'll have to update the notebook test data for this one...

@philippjfr philippjfr added this to the v1.7.0 milestone Nov 16, 2016

@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 4, 2017

Going to close this as it has been superseded by #1238.

@philippjfr philippjfr closed this Apr 4, 2017

@jlstevens

This comment has been minimized.

Member

jlstevens commented Apr 4, 2017

I think this point is still valid:

  • Make sure we are clear about get_dynamic_item and associated semantics.
@philippjfr

This comment has been minimized.

Member

philippjfr commented Apr 4, 2017

Sure, we can discuss that in #1240, which reimplements get_dynamic_item.

@philippjfr philippjfr deleted the counter_mode_deprecation branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment