New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty layout now display as text repr #981

Merged
merged 4 commits into from Nov 8, 2016

Conversation

Projects
None yet
2 participants
@jlstevens
Member

jlstevens commented Nov 8, 2016

This PR addresses #980 by raising SkipRendering for empty layouts. In addition, it adds a warn option to SkipRendering making it possible to suppress the usual warning.

@jlstevens

This comment has been minimized.

Member

jlstevens commented Nov 8, 2016

@philippjfr I think this PR is ready to review/merge now.

@philippjfr

This comment has been minimized.

Member

philippjfr commented Nov 8, 2016

Looks good and is sensible. Will merge.

@philippjfr philippjfr merged commit f2268e9 into master Nov 8, 2016

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 75.711%
Details
s3-reference-data-cache Test data is cached.
Details

@jbednar jbednar deleted the empty_layout_fix branch Nov 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment