Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codecov reporting. #2322

Merged
merged 8 commits into from
Oct 2, 2019
Merged

Add Codecov reporting. #2322

merged 8 commits into from
Oct 2, 2019

Conversation

jezdez
Copy link
Contributor

@jezdez jezdez commented Oct 2, 2019

This also restructures the way the Circle config calls the tests a bit by extending the bin/run script.

Pull Request checklist

  • Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • Changelog: This PR updates the changelog with any user-visible changes.
  • Tests: This PR includes thorough tests or an explanation of why it does not

jezdez added 2 commits October 2, 2019 13:01
This also restructures the way the Circle config calls the tests a bit by extending the bin/run script.
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7081094). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2322   +/-   ##
=========================================
  Coverage          ?   69.36%           
=========================================
  Files             ?      220           
  Lines             ?     5331           
  Branches          ?      853           
=========================================
  Hits              ?     3698           
  Misses            ?     1605           
  Partials          ?       28
Impacted Files Coverage Δ
server/tests/plugins/staticfiles.py 87.5% <ø> (ø)
server/tests/plugins/lean.py 77.77% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7081094...08d735d. Read the comment docs.

@jezdez jezdez requested a review from wlach October 2, 2019 13:37
Copy link
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minus the changelog issue

jezdez and others added 2 commits October 2, 2019 17:55
Co-Authored-By: William Lachance <wlachance@mozilla.com>
Co-Authored-By: William Lachance <wlachance@mozilla.com>
@jezdez jezdez merged commit 1543a85 into master Oct 2, 2019
@jezdez jezdez deleted the codecov branch October 2, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants