-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add meta tags to render links on social media #2344
Conversation
@wlach, I think these are the meta tags needed to make the links rendered nicely on twitter and facebook. since we don't have small descriptions, I just duped the title for the description. since I haven't taken the time to properly learn django, I'm not certain if that is the correct pattern for inserted the title into the html |
Codecov Report
@@ Coverage Diff @@
## master #2344 +/- ##
===========================================
- Coverage 69.61% 59.42% -10.19%
===========================================
Files 222 170 -52
Lines 5469 3783 -1686
Branches 872 754 -118
===========================================
- Hits 3807 2248 -1559
+ Misses 1637 1535 -102
+ Partials 25 0 -25 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close, I think one property should be derived from a setting, in case people are sharing from other instances of iodide. To make them available to every template without having to specify them many times, we can use a context processor. See this stackoverflow question:
https://stackoverflow.com/a/433209
Also, could you add an entry to CHANGELOG.md
?
server/templates/base.html
Outdated
<meta property="og:title" content="{{ title }}"> | ||
<meta property="og:description" content="{{ title }}"> | ||
<meta property="og:image" content="https://files.gitter.im/iodide-project/iodide/xW1J/iodide-sticker-2.png"> | ||
<meta property="og:url" content="https://iodide.io"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be derived from settings.SITE_URL
hey @teonbrooks, will you have time to look into this in the next couple days? I'd like to get this in before the next iodide release |
I adjusted the comments for the meta tags, but other than that, this looks great! I will merge. |
No description provided.