Await script load before continuing evaluation in iodide (fixes #1278) #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-project#1278) We were already waiting for the network, but should also be waiting for the DOM event that the script has been evaluated.
wlach
force-pushed
the
await-script-load-before-continuing
branch
from
25fadfa to
7d08bdf
Compare
|
This fixes all the issues I can see in production. I'm not sure offhand how best to write a test case for this: this is a pretty big papercut and I'm kind of inclined just to merge if that's ok with people. |
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
=======================================
Coverage 69.58% 69.58%
=======================================
Files 223 223
Lines 5464 5464
Branches 877 877
=======================================
Hits 3802 3802
Misses 1643 1643
Partials 19 19 |
mdboom
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already waiting for the network, but should also be waiting
for the DOM event that the script has been evaluated.
Pull Request checklist