Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency check for the builds. #568

Merged
merged 3 commits into from Nov 19, 2019

Conversation

@dorianpula
Copy link
Contributor

dorianpula commented Nov 19, 2019

Add a target and a script that will check if the dev dependencies are installed.

Copy link
Member

mdboom left a comment

Looks good, pending passing tests and one minor change.

tools/dependency-check.sh Outdated Show resolved Hide resolved
@dorianpula dorianpula requested a review from mdboom Nov 19, 2019
.gitignore Show resolved Hide resolved
@mdboom
mdboom approved these changes Nov 19, 2019
@mdboom mdboom merged commit a1663e7 into iodide-project:master Nov 19, 2019
4 of 5 checks passed
4 of 5 checks passed
ci/circleci: test-chrome Your tests failed on CircleCI
Details
ci/circleci: benchmark Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-firefox Your tests passed on CircleCI!
Details
ci/circleci: test-python Your tests passed on CircleCI!
Details
@dorianpula dorianpula deleted the dorianpula:add-makefile-dev-dep-check branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.