Fix tests until 2049 #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioflo/aio/test/tls/certs/client_cert.pem had
Not After : Sep 15 17:08:16 2019 GMT
and thus 8 tests were failing.
The certs were updated using gnutls'
certtool -u \
--load-ca-privkey ioflo/aio/test/tls/certs/client_key.pem \
--load-ca-certificate ./ioflo/aio/test/tls/certs/client_cert.pem \
--load-certificate ./ioflo/aio/test/tls/certs/client_cert.pem > x
with an expiry of 11000 days.
Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.
See https://reproducible-builds.org/ for why this matters.
|
Was fixed by 42e7f63 though its commit message could have been better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix tests until 2049
This change is necessary because
openssl x509 -text -in ioflo/aio/test/tls/certs/client_cert.pemhadNot After : Sep 15 17:08:16 2019 GMTand thus 8 tests were failing.
The certs were updated using gnutls' certtool
certtool -u \ --load-ca-privkey ioflo/aio/test/tls/certs/client_key.pem \ --load-ca-certificate ./ioflo/aio/test/tls/certs/client_cert.pem \ --load-certificate ./ioflo/aio/test/tls/certs/client_cert.pem > xwith an expiry of 11000 days.
I tested that everything still passes in 2034.
Background:
As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our package build.
See https://reproducible-builds.org/ for why this matters.