Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML-LD functions won't recognize an str as a URL or file path #37

Closed
anatoly-scherbakov opened this issue Mar 30, 2024 · 1 comment
Closed
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@anatoly-scherbakov
Copy link
Contributor

Why

Currently, we rely upon URL or Path types to distinguish between different methods to specify location of the file we're processing. When provided with an str, we will always interpret it as a YAML-LD document content.

What

Write an ADR about this.

  • Either keep it as is,
  • Or implement some kind of heuristic to recognize paths and URLs encoded in plain str instances.
@anatoly-scherbakov anatoly-scherbakov added bug Something isn't working documentation Improvements or additions to documentation labels Mar 30, 2024
@anatoly-scherbakov
Copy link
Contributor Author

Works already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant