From d5d195c947f3e68040c99fe613b4cbed3333a8af Mon Sep 17 00:00:00 2001
From: Derick Turner <derick@e-learndesign.co.uk>
Date: Fri, 22 Sep 2023 11:46:05 +0100
Subject: [PATCH] IOMAD: Logic not quite right on cert regeneration.

---
 local/iomad_track/db/install.php   | 2 ++
 local/report_completion/index.php  | 6 +++---
 local/report_users/newentry.php    | 2 +-
 local/report_users/userdisplay.php | 6 +++---
 4 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/local/iomad_track/db/install.php b/local/iomad_track/db/install.php
index 537ead737fe..ed03a684778 100644
--- a/local/iomad_track/db/install.php
+++ b/local/iomad_track/db/install.php
@@ -133,6 +133,8 @@ function xmldb_local_iomad_track_record_certificates($courseid, $userid, $tracki
     // Get context
     $context = context_course::instance($courseid);
 
+mtrace ("generating certificate with onlyvisible = $onlyvisible</br>");
+die;
     // Get user
     $user = $DB->get_record('user', array('id' => $userid), '*', MUST_EXIST);
 
diff --git a/local/report_completion/index.php b/local/report_completion/index.php
index 1e95e6d1910..eedfe8f2fab 100644
--- a/local/report_completion/index.php
+++ b/local/report_completion/index.php
@@ -318,7 +318,7 @@
                     // Re-generate the certificate.
                     if ($trackrec = $DB->get_record('local_iomad_track', array('id' => $key))) {
                         local_iomad_track_delete_entry($key);
-                        xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, true);
+                        xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, false);
                     }
                 }
             }
@@ -362,7 +362,7 @@
 
                         // Re-generate the certificate.
                         local_iomad_track_delete_entry($key);
-                        xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, true);
+                        xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, false);
                     }
                 }
             }
@@ -376,7 +376,7 @@
         if ($action == 'redocert' && !empty($redocertificate)) {
             if ($trackrec = $DB->get_record('local_iomad_track', array('id' => $redocertificate))) {
                 local_iomad_track_delete_entry($redocertificate);
-                if (xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, true)) {
+                if (xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, false)) {
                     redirect(new moodle_url('/local/report_completion/index.php', $params),
                              get_string($action . "_successful", 'local_report_users'),
                              null,
diff --git a/local/report_users/newentry.php b/local/report_users/newentry.php
index 9b92da10b84..8fc2538f339 100644
--- a/local/report_users/newentry.php
+++ b/local/report_users/newentry.php
@@ -107,7 +107,7 @@
     $trackid = $DB->insert_record('local_iomad_track', $newentry);
 
     // Create a certificate, if required.
-    xmldb_local_iomad_track_record_certificates($newentry->courseid, $newentry->userid, $trackid, false, true);
+    xmldb_local_iomad_track_record_certificates($newentry->courseid, $newentry->userid, $trackid, false, false);
 
     // Return success.
     redirect($returnurl,
diff --git a/local/report_users/userdisplay.php b/local/report_users/userdisplay.php
index 483790c1eda..c51120342ca 100644
--- a/local/report_users/userdisplay.php
+++ b/local/report_users/userdisplay.php
@@ -206,7 +206,7 @@
                     // Re-generate the certificate.
                     if ($trackrec = $DB->get_record('local_iomad_track', array('id' => $key))) {
                         local_iomad_track_delete_entry($key);
-                        xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, true);
+                        xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, false);
                     }
                 }
             }
@@ -250,7 +250,7 @@
 
                         // Re-generate the certificate.
                         local_iomad_track_delete_entry($key);
-                        xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, true);
+                        xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, false);
                     }
                 }
             }
@@ -272,7 +272,7 @@
         if ($action == 'redocert' && !empty($redocertificate)) {
             if ($trackrec = $DB->get_record('local_iomad_track', array('id' => $redocertificate))) {
                 local_iomad_track_delete_entry($redocertificate);
-                if (xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, true)) {
+                if (xmldb_local_iomad_track_record_certificates($trackrec->courseid, $trackrec->userid, $trackrec->id, false, false)) {
                     redirect(new moodle_url('/local/report_users/userdisplay.php', array('userid' => $userid)),
                              get_string($action . "_successful", 'local_report_users'),
                              null,