From 846acb999ef3b5a9b2fec70315e7fb21920e79c7 Mon Sep 17 00:00:00 2001 From: Alexandre Jacinto Date: Thu, 30 Jan 2025 16:02:14 +0000 Subject: [PATCH 1/3] chore: update dependency to Android native lib --- android/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/build.gradle b/android/build.gradle index 8a263f9..a46bc8e 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -58,7 +58,7 @@ repositories { dependencies { // implementation fileTree(dir: 'libs', include: ['*.jar']) implementation project(':capacitor-android') - implementation "com.capacitorjs:osinappbrowser-android:1.2.1" + implementation "io.ionic.libs:ioninappbrowser-android:1.2.1" implementation 'androidx.browser:browser:1.8.0' implementation "androidx.constraintlayout:constraintlayout:2.2.0" implementation "androidx.appcompat:appcompat:$androidxAppCompatVersion" From d1da7792c7fad45822c5855d287e6435e47a776a Mon Sep 17 00:00:00 2001 From: Alexandre Jacinto Date: Thu, 30 Jan 2025 16:17:41 +0000 Subject: [PATCH 2/3] fix: don't use release token for `basic-tests` workflow --- .github/workflows/basic-tests.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/basic-tests.yml b/.github/workflows/basic-tests.yml index 008470b..65e8350 100644 --- a/.github/workflows/basic-tests.yml +++ b/.github/workflows/basic-tests.yml @@ -9,17 +9,11 @@ on: jobs: setup: uses: ./.github/workflows/reusable_setup.yml - secrets: - THE_GH_RELEASE_TOKEN: ${{ secrets.CAP_GH_RELEASE_TOKEN }} lint-test: needs: 'setup' uses: ./.github/workflows/reusable_lint.yml - secrets: - THE_GH_RELEASE_TOKEN: ${{ secrets.CAP_GH_RELEASE_TOKEN }} build-packages: needs: 'setup' - uses: ./.github/workflows/reusable_build.yml - secrets: - THE_GH_RELEASE_TOKEN: ${{ secrets.CAP_GH_RELEASE_TOKEN }} \ No newline at end of file + uses: ./.github/workflows/reusable_build.yml \ No newline at end of file From 21ab69e7b0f1bf82bd3eb979a5be4ab1ae01f7a8 Mon Sep 17 00:00:00 2001 From: Alexandre Jacinto Date: Thu, 30 Jan 2025 16:21:00 +0000 Subject: [PATCH 3/3] fix: make release token not mandatory in build, lint, and setup workflows --- .github/workflows/reusable_build.yml | 4 ++-- .github/workflows/reusable_lint.yml | 4 ++-- .github/workflows/reusable_setup.yml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/reusable_build.yml b/.github/workflows/reusable_build.yml index 68c529a..3b471af 100644 --- a/.github/workflows/reusable_build.yml +++ b/.github/workflows/reusable_build.yml @@ -4,7 +4,7 @@ on: workflow_call: secrets: THE_GH_RELEASE_TOKEN: - required: true + required: false jobs: build: @@ -14,7 +14,7 @@ jobs: - uses: actions/checkout@v4 with: fetch-depth: 0 - token: ${{ secrets.THE_GH_RELEASE_TOKEN }} + token: ${{ secrets.THE_GH_RELEASE_TOKEN || github.token }} - name: 'Setup Tools' uses: ./.github/actions/setup-tools diff --git a/.github/workflows/reusable_lint.yml b/.github/workflows/reusable_lint.yml index 45fd180..bff3b72 100644 --- a/.github/workflows/reusable_lint.yml +++ b/.github/workflows/reusable_lint.yml @@ -4,7 +4,7 @@ on: workflow_call: secrets: THE_GH_RELEASE_TOKEN: - required: true + required: false jobs: lint: @@ -14,7 +14,7 @@ jobs: - uses: actions/checkout@v4 with: fetch-depth: 0 - token: ${{ secrets.THE_GH_RELEASE_TOKEN }} + token: ${{ secrets.THE_GH_RELEASE_TOKEN || github.token }} - name: 'Setup Tools' uses: ./.github/actions/setup-tools diff --git a/.github/workflows/reusable_setup.yml b/.github/workflows/reusable_setup.yml index 51fbd32..95aa941 100644 --- a/.github/workflows/reusable_setup.yml +++ b/.github/workflows/reusable_setup.yml @@ -4,7 +4,7 @@ on: workflow_call: secrets: THE_GH_RELEASE_TOKEN: - required: true + required: false jobs: setup: @@ -17,7 +17,7 @@ jobs: - uses: actions/checkout@v4 with: fetch-depth: 0 - token: ${{ secrets.THE_GH_RELEASE_TOKEN }} + token: ${{ secrets.THE_GH_RELEASE_TOKEN || github.token }} - name: 'Setup Tools' uses: ./.github/actions/setup-tools \ No newline at end of file