Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(@capacitor/screen-orientation): iOS landscape lock using incorrect mappings #2049

Merged
merged 1 commit into from
Apr 18, 2024
Merged

bug(@capacitor/screen-orientation): iOS landscape lock using incorrect mappings #2049

merged 1 commit into from
Apr 18, 2024

Conversation

brian-weasner
Copy link
Contributor

Fixes #2022

@brian-weasner
Copy link
Contributor Author

Any timeline for when this will be reviewed?
Asking because this is bugfix is a blocker for our applications to move from cordova-plugin-screen-orientation to this plugin.

@OS-ricardomoreirasilva OS-ricardomoreirasilva merged commit f08fa11 into ionic-team:5.x Apr 18, 2024
OS-ricardomoreirasilva pushed a commit that referenced this pull request Apr 18, 2024
@brian-weasner @OS-ricardomoreirasilva
bug(@capacitor/screen-orientation): iOS landscape lock using incorrec…
c3a8317 
…t mappings (#2049)
@brian-weasner brian-weasner deleted the hotfix/screen-orientation-2022 branch April 18, 2024 14:07
NetEvolutions added a commit to werktools/capacitor-plugins that referenced this pull request May 27, 2024
@NetEvolutions
Merge commit 'c4feee0846830308a38154b9c1538031b374e2b8' into ios-loca…
4c4407a 
…tion-aware-camera-5.x

* commit 'c4feee0846830308a38154b9c1538031b374e2b8':
  fix(ios): apply filter to fetch correct scene object (ionic-team#2103)
  fix(ios): Picking ProRAW pictures from Gallery (ionic-team#2098) (ionic-team#2099)
  fix(android): removes setOnExitAnimationListener when fade out is disabled
  fix(ios): iOS panorama photos selected through CameraPlugin are corrupted (ionic-team#2088)
  bug(@capacitor/screen-orientation): iOS landscape lock using incorrect mappings (ionic-team#2049)
  chore: Update install instructions with latest-5 tag (ionic-team#2084)
  chore: publish as latest-5 (ionic-team#2081)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IT-MikeS IT-MikeS IT-MikeS approved these changes

@OS-ricardomoreirasilva OS-ricardomoreirasilva OS-ricardomoreirasilva approved these changes

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD

@dallastjames dallastjames Awaiting requested review from dallastjames

@alexgerardojacinto alexgerardojacinto Awaiting requested review from alexgerardojacinto

@OS-martacarlos OS-martacarlos Awaiting requested review from OS-martacarlos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brian-weasner @IT-MikeS @OS-ricardomoreirasilva