Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(share): Prevent share if sharing in progress #489

Merged
merged 4 commits into from Jun 24, 2021
Merged

Conversation

@jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Jun 18, 2021

If you call share twice in a row it causes issues, on android two sheets appear but both return the result of the first one, on iOS the second one is not presented and the promise never resolves nor rejects.

This PR detects if a share is in progress and prevent it rejecting with an error-

closes #323

@Ionitron Ionitron added this to Needs review 🤔 in Capacitor Engineering ⚡️ Jun 18, 2021
@jcesarmobile jcesarmobile merged commit 3479783 into main Jun 24, 2021
5 checks passed
5 checks passed
@github-actions
setup
Details
@github-actions
lint lint
Details
@github-actions
verify-ios (share)
Details
@github-actions
verify-android (share)
Details
@github-actions
verify-web (share)
Details
@jcesarmobile jcesarmobile deleted the multiple-shares branch Jun 24, 2021
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants