From 48ff9e6461e8037a5c6da87c90efc6bc872d7f08 Mon Sep 17 00:00:00 2001 From: jcesarmobile Date: Thu, 4 Aug 2022 17:10:49 +0200 Subject: [PATCH] fix(cli): Don't add google-services plugin if missing (#5825) --- cli/src/tasks/migrate.ts | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/cli/src/tasks/migrate.ts b/cli/src/tasks/migrate.ts index 287e7d9fe4..9af9a99020 100644 --- a/cli/src/tasks/migrate.ts +++ b/cli/src/tasks/migrate.ts @@ -460,7 +460,7 @@ async function updateBuildGradle( ) { // In build.gradle add dependencies: // classpath 'com.android.tools.build:gradle:7.2.1' - // classpath 'com.google.gms:google-services:4.3.10' + // classpath 'com.google.gms:google-services:4.3.13' const txt = readFile(filename); if (!txt) { return; @@ -474,13 +474,7 @@ async function updateBuildGradle( let replaced = txt; for (const dep of Object.keys(neededDeps)) { - if (!replaced.includes(`classpath '${dep}`)) { - replaced = txt.replace( - 'dependencies {', - `dependencies {\n classpath '${dep}:${neededDeps[dep]}'`, - ); - } else { - // Update + if (replaced.includes(`classpath '${dep}`)) { replaced = setAllStringIn( replaced, `classpath '${dep}:`,