Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Don't warn about hideLogs on some commands #4813

Merged
merged 4 commits into from Jul 9, 2021
Merged

Conversation

@jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Jul 8, 2021

At the moment, if the user has hideLogs configuration option, the CLI will show a warning on every command the CLI runs.
For some commands (version, config, run) it's a problem because the output is used by other tooling (like Ionic CLI) and can't be parsed correctly.

This moves the warning from all commands to just a set of them (add, update, copy, sync, doctor, list)

@Ionitron Ionitron added this to Needs review 🤔 in Capacitor Engineering ⚡️ Jul 8, 2021
@jcesarmobile jcesarmobile merged commit dc279cc into main Jul 9, 2021
16 checks passed
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Jul 9, 2021
@jcesarmobile jcesarmobile deleted the hidelogs-warning branch Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants