Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Set theme an content view on onCreate #4841

Merged
merged 1 commit into from Jul 16, 2021
Merged

Conversation

@jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Jul 16, 2021

In Capacitor 2 the theme and contentView were set in onCreate (because the init method was called on onCreate), now in Capacitor 3 are set on onStart (because init is deprecated), which seems to be too late for the themes to properly work.

closes #4787

@jcesarmobile jcesarmobile merged commit 8950c60 into main Jul 16, 2021
17 checks passed
@jcesarmobile jcesarmobile deleted the set-theme-create branch Jul 16, 2021
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Linked issues

Successfully merging this pull request may close these issues.

2 participants