-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 12.2 scroll hangs #326
Comments
@BumbleeLin - do you happen to have reproduction steps & a sample application that exhibits the issue? I'm working with someone on a similar issue, but haven't yet experienced this issue myself. If you have the chance to write up a simple demo app and post that here, that'd be great! Edit: Additionally, if you can post more information about your app environment (post the outputs of |
@Baadier-Sydow you're also welcome to post a sample application if this is an issue for you :) we're trying to look into it but have no viable reproduction steps / sample app at the moment. |
@bryplano awesome. I will try to help with a sample app. See below the Ionic info: cli packages: (/usr/local/lib/node_modules)
global packages:
local packages:
System:
Environment Variables:
Misc:
----------------------------> Below is the plugin list : com-sarriaroman-photoviewer 1.1.10 "PhotoViewer" I will continue to dig deeper into this issue and let you know if I have any updates. |
@BumbleeLin awesome! Thank you so much :) we're working on it from our end as well, so we'll be sure to update if we find anything. |
Here is a sample app that shows the behavior: https://github.com/kensodemann/test-scroll Run on a phone that is running iOS 12.2 Beta 4 On home, press the button, which opens a child that will not scroll. |
@bryplano I'm on the same team as @BumbleeLin Unfortunately the project is too large for us to create something reproducible as we arent sure on the root cause. It seems like @kensodemann may have something that can help. |
@kensodemann @bryplano What @BumbleeLin didnt mention is that even after that change we have one or two screens that still dont work. We are going to see if we can find the root cause but arent really making any headway. |
@Baadier-Sydow no problem! Thanks for clarifying and thanks to @kensodemann for the demo app. We're taking a look at this on our end and will post once we have any update. |
I wrote up a separate issue for the Ionic v3 repo: ionic-team/ionic-v3#984 Probably best to follow both issues as last I checked, the team is working on determining where a fix would come from. Suspicion is a Webkit / Safari issue but still working it out :) |
I'm going to add another issue that was up by one our testers both here and on the v3 repo as it could be linked. We have a feature that opens an external site in an inappbrowser and then returns back to the application. We started with the Ionic side menu starter and according to the testers the menu intermittently stops responding to the press to open it ie the menu does not slide open when we get focus back from the inappbrowser. This was working prior to iOS 12.2. |
I think it has been fixed on 12.2 beta 6 |
@BumbleeLin - I have closed my issue on the v3 repo because the problem no longer exists after installing iOS 12.2 Beta 6 (released earlier this week). Reference: ionic-team/ionic-v3#984 Could you check and see if you still have issues? |
Thanks @bryplano @BumbleeLin and I will have a look 👍 |
@bryplano cool bro, will give you feedback on this |
@bryplano yo man, I'm still not having any luck with the scroll issue. Do you perhaps have any other suggestions? I have updated the device to iOS 12.2 beta 6 and used XCode 10.2 beta 4. |
@BumbleeLin - I'd recommend updating to the iOS 12.2 GA release and Xcode 10.2 GA release as well. Do you have a simple sample application that exhibits this behavior? Beyond that, does the scroll issue occur with and without Apple has made some changes to Webkit as part of this 12.2 release (which we found out was causing the scrolling issue I mentioned in my previous post), so it could be there are other weird issues there too. |
@bryplano thanks. I'm busy with the update at the moment. I will let you know once I have done this. Thanks! |
Did you solve this issue? I tried updating/upgrading several packages with no luck so far... |
@phpfs we still havent been able to test. @BumbleeLin and I are having issues with the latest update to Xcode. But, we'll update here as soon as we know more. |
I'm experiencing this issue as well on the simulator and device. I'm using Ionic v3 and XCode 10.2. |
@daviddickson, have you seen if this occurs without the webview plugin installed (per my previous comment)? It would be worth trying to reproduce the problem in a simple sample application - like I said, with the Webkit changes in 12.2, I wouldn't be surprised if this is actually a Webkit bug, but it could be an issue with |
@bryplano Thank you for the quick response. I appreciate it. I just created a sample app with the webview plugin installed and with the html where I'm experiencing the issue but I'm not able to reproduce it in the sample app. |
@daviddickson can you show your plugin list? |
In the sample app:
|
In the app where I'm experiencing the issue:
|
Maybe bump you webview plugin to sample app version? |
I removed it using |
@daviddickson kak me too. No luck with Xcode 10.2. |
I tried installing |
@BumbleeLin I can confirm the fix you put in the initial post works for me. |
@phpfs is the fix a work around for now? |
@daviddickson this fix works - ionic-team/ionic-v3#989 |
Currently the app I'm working on is at the finish line for a MVP and I'm hesitant to make environment/Ionic CLI changes because I'm not comfortable with the inner workings of what's going on here. That being said would a step by step walkthrough of what you said look like this? -
|
@daviddickson |
@daviddickson Did you have any luck? |
@phpfs I haven't tried. I'm going to hold off. |
@daviddickson , the fix should be within ionic-angular nightly build 3.9.4-201903121725 as far as I know |
@daviddickson if the initial fix works for you then I think you should be safe. I also don't think that you need to update your version of Ionic to get the fix, you can manually apply the code that fixes it from the Ionic V3 repo. If you want to take the latter approach then let me know I can help you with that :) |
@BumbleeLin I'm just going to stick with the initial fix for now. Thanks for offering to help. :) |
Does anyone know how to fix this if I use this plugin inside a ionic-less cordova app ? I'm open to any kind of solution. |
@simlevesque please see first comment in issue |
I have the same issue. Any solution or workaround for this problem? |
See my comment above: If you use ionic, follow ionic-team/ionic-v3#984 (comment) :) |
i've installed this specific version of ionic npm i ionic-angular@3.9.4-201903121725 |
After updating try to rebuild your project or platforms |
Ok i will try and I'll let you know. |
I've tried with rebuild and re-added platform but doesn't work. :| Any solution? |
@filippodicostanzo Okay try below, if it doesn't work then you are more than welcomed to contact me directly : In Xcode > Plugins/CDVWKWebViewEngine.m file on the (void)handleStopScroll method change the last line from - a) To - b) |
@BumbleeLin yes I tried this too but it doesn't work. How to contact directly? The testing is very fast. ionic cordova add platform ios just run on a real device and if you change the page from menu the scroll of page doesnt' work. I repeat the problem only occurs on devices with iOS 12.2 |
This totally solves it for me. Add this to your scss:
|
Confirmed as working for me! Really appreciate it. |
This works great, but I'm having the same issue on action sheets and adding the same css to |
FYI I had an issue on Ionic3 with webview and i removed these dependencies and the issue was fixed:
|
I have similar issue. Scroll works but keep sticky in ios 12.2 |
This works for me. i.e
.css
|
Add this line to your config.xml file:
|
Our app seems to have the scrolling hang on certain pages. In the CDVWKWebViewEngine.m file on the (void)handleStopScroll method when I change the last line from -
a)
[wkWebView evaluateJavaScript:@"window.IonicStopScroll.fire()" completionHandler:nil];
To -
b)
[wkWebView evaluateJavaScript:@"window.IonicStopScroll.cancel()" completionHandler:nil];
The scrolling then seems to work. I'm not sure if there is an issue with this section in the wk-plugin.js file -
The text was updated successfully, but these errors were encountered: