New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ionic g page should use IonicPageModule #2070

Closed
brandyscarney opened this Issue Apr 6, 2017 · 12 comments

Comments

Projects
None yet
@brandyscarney
Member

brandyscarney commented Apr 6, 2017

From @geykel on April 5, 2017 19:22

Type: bug

Ionic Version: 3.x

Platform: all

When using the Ionic cli generate command for generating pages, the page module tempate is using IonicModule instead of IonicPageModule.

Reproduce:

ionic g page login

This is my current dev environment:

cordova CLI: 6.5.0
Ionic Framework Version: 3.0.0
Ionic CLI Version: 2.2.2
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.3.0
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.9.5
Xcode version: Not installed

Copied from original issue: ionic-team/ionic#11076

@jgw96

This comment has been minimized.

Show comment
Hide comment
@jgw96

jgw96 Apr 10, 2017

Contributor

This was fixed by a community member in the framework.

Contributor

jgw96 commented Apr 10, 2017

This was fixed by a community member in the framework.

@jgw96 jgw96 closed this Apr 10, 2017

@santiph

This comment has been minimized.

Show comment
Hide comment
@santiph

santiph Apr 10, 2017

@jgw96 So I think I've been affected by this issue by trying to create a new page and seeing a new module also being created.
What should be done to get the create page command working again? (Update/reinstall/download anything?)

santiph commented Apr 10, 2017

@jgw96 So I think I've been affected by this issue by trying to create a new page and seeing a new module also being created.
What should be done to get the create page command working again? (Update/reinstall/download anything?)

@chikehenderson

This comment has been minimized.

Show comment
Hide comment
@chikehenderson

chikehenderson commented Apr 13, 2017

nice one

@sofqi

This comment has been minimized.

Show comment
Hide comment
@sofqi

sofqi Apr 14, 2017

Even though this is closed, I just updated everything today, created a new project using
ionic start ion3 sidemenu --v2
created a new component using
ionic g component testcomponent
then
ionic emulate ios --target="iPhone-6s";date
and quickly got the error
Property 'forChild' does not exist on type 'typeof IonicModule'.

Fix is to replace IonicModule with IonicPageModule in test component.module.ts

sofqi commented Apr 14, 2017

Even though this is closed, I just updated everything today, created a new project using
ionic start ion3 sidemenu --v2
created a new component using
ionic g component testcomponent
then
ionic emulate ios --target="iPhone-6s";date
and quickly got the error
Property 'forChild' does not exist on type 'typeof IonicModule'.

Fix is to replace IonicModule with IonicPageModule in test component.module.ts

@Eraldo

This comment has been minimized.

Show comment
Hide comment
@Eraldo

Eraldo Apr 15, 2017

I can confirm this. :)

I also want to say that the reason this error is there is great!
Thanks a lot for working on the new modularised page loading mechanism. ;)

Eraldo commented Apr 15, 2017

I can confirm this. :)

I also want to say that the reason this error is there is great!
Thanks a lot for working on the new modularised page loading mechanism. ;)

@jdell64

This comment has been minimized.

Show comment
Hide comment
@jdell64

jdell64 Apr 17, 2017

Unless I'm doing something terribly wrong, this is not fixed yet. A work around has been identified, but the root cause has not been fixed, right?

jdell64 commented Apr 17, 2017

Unless I'm doing something terribly wrong, this is not fixed yet. A work around has been identified, but the root cause has not been fixed, right?

@p1ll0wf0rtress

This comment has been minimized.

Show comment
Hide comment
@p1ll0wf0rtress

p1ll0wf0rtress Apr 18, 2017

I'm also very interested in this.

p1ll0wf0rtress commented Apr 18, 2017

I'm also very interested in this.

@jawad-aziz-farhad

This comment has been minimized.

Show comment
Hide comment
@jawad-aziz-farhad

jawad-aziz-farhad Apr 18, 2017

In the new Created Page,There is a Typescript File having name like this:
"PageName.module.ts" , In this file, Change IonicModule to IonicPageModule.
and you are done.

jawad-aziz-farhad commented Apr 18, 2017

In the new Created Page,There is a Typescript File having name like this:
"PageName.module.ts" , In this file, Change IonicModule to IonicPageModule.
and you are done.

@jdell64

This comment has been minimized.

Show comment
Hide comment
@jdell64

jdell64 Apr 18, 2017

@jawad-aziz-farhad that isn't a fix, it's a workaround. This issue should be tracked somewhere, so if not in this ticket, which one?

jdell64 commented Apr 18, 2017

@jawad-aziz-farhad that isn't a fix, it's a workaround. This issue should be tracked somewhere, so if not in this ticket, which one?

@surajrao

This comment has been minimized.

Show comment
Hide comment
@surajrao

surajrao Apr 18, 2017

@jdell64 check this ionic-team/ionic#11077 it will probably be in the next version . As mentioned :

it will be in the next Ionic release. You could also just copy/paste the change into node_modules/ionic-angular/templates.

surajrao commented Apr 18, 2017

@jdell64 check this ionic-team/ionic#11077 it will probably be in the next version . As mentioned :

it will be in the next Ionic release. You could also just copy/paste the change into node_modules/ionic-angular/templates.

@jdell64

This comment has been minimized.

Show comment
Hide comment
@jdell64

jdell64 commented Apr 18, 2017

Thanks!

@judsonmusic

This comment has been minimized.

Show comment
Hide comment
@judsonmusic

judsonmusic Sep 27, 2017

Did this ever get resolved? If so what do I need to update to see the change?

judsonmusic commented Sep 27, 2017

Did this ever get resolved? If so what do I need to update to see the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment