Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cordova-plugin-crosswalk-webview from plugins on crosswalk revert #358

Conversation

@mattezell
Copy link

commented Apr 7, 2015

Removing 'cordova-plugin-crosswalk-webview' from plugins when running 'ionic browser revert android' as plugin is crosswalk resource and so should no longer remain after reverting to Android browser - presence of this plugin caused failure of subsequent attempts to run 'ionic platform add android' after removal of Android platform from project.

…osswalk via 'browser revert android'

Removing 'cordova-plugin-crosswalk-webview' from plugins when running 'ionic browser revert android' as plugin is crosswalk resource and so should no longer remain after reverting to Android browser - presence of this plugin caused failure of subsequent attempts to run 'ionic platform add android' after removal of Android platform from project.
@mattezell

This comment has been minimized.

Copy link
Author

commented Apr 7, 2015

Note: corresponds with an issue I incorrectly opened in the 'ionic' project - ionic-team/ionic#3482

jbavari added a commit that referenced this pull request Apr 8, 2015
…-revert-android

Remove cordova-plugin-crosswalk-webview from plugins on crosswalk revert
@jbavari jbavari merged commit 3e34383 into ionic-team:master Apr 8, 2015
@jbavari

This comment has been minimized.

Copy link

commented Apr 8, 2015

Thanks for the contribution!

@mattezell

This comment has been minimized.

Copy link
Author

commented Apr 8, 2015

Anytime! Thank you guys for the continued hard work and investment into the ecosystem!

@mattezell mattezell deleted the mattezell:3482-crosswalk-cleanup-browser-revert-android branch Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.