Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rejectUnauthorized option to the proxy configuration to allow untrusted certificates #404

Closed
wants to merge 1 commit into from

Conversation

nzamani
Copy link

@nzamani nzamani commented Apr 28, 2015

See http://forum.ionicframework.com/t/how-to-use-a-proxy-to-https-services/21854/2

This change allows the proxy to accept untrusted certificates, i.e. when proxying to a server on localhost + https

See http://forum.ionicframework.com/t/how-to-use-a-proxy-to-https-services/21854/2

This change allows to allow untrusted certificates, i.e. when proxying to a server on localhost + https
@jbavari
Copy link

jbavari commented Apr 30, 2015

@nzamani As a heads up, going forward we've ripped out a lot of code from the CLI to put it into its own library. In this library, the code you propose has been merged. Thank you for the contribution!

@jbavari jbavari closed this Apr 30, 2015
@nzamani
Copy link
Author

nzamani commented May 1, 2015

@jbavari Good to hear, Thanks! Do you already know when and in what version this feature will be available? The reason I ask is because I wanna make sure that our "local" change does not disappear by an update of ionic-cli that does not include the change...

@nzamani
Copy link
Author

nzamani commented May 23, 2015

Just in case anyone is interested:
It seems that after the refactoring the feature has moved from ionic-cli to ionic-app-lib. There you can check lib/serve.js, see here:

https://github.com/driftyco/ionic-app-lib/blob/2dece25d83d9149d900766bd5dc6d1e5780a1091/lib/serve.js#L317

or https://github.com/driftyco/ionic-app-lib/blob/master/lib/serve.js#L317

@jbavari
Copy link

jbavari commented May 24, 2015

@nzamani Thanks for sharing that knowledge and those links. This will be helpful.

I'm also updating the wiki to give instructions on how/why it is laid out this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants